Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise fill-human-* doc strings #641

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Aug 20, 2024

Point user at fill-human-el for details on opts.

Closes issue #637.

Please complete and include the following checklist:

  • [x ] I have read CONTRIBUTING and the Etaoin Developer Guide.

  • [x ] This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • [x ] This PR contains test(s) to protect against future regressions (NOT NEEDED)

  • [x ] I have updated CHANGELOG.adoc with a description of the addressed issue. (NOT NEEDED)

Point user at fill-human-el for details on `opts`. Issue 637.
@lread
Copy link
Collaborator

lread commented Aug 20, 2024

Thanks @dgr!

@lread lread merged commit 5d9d3ac into clj-commons:master Aug 20, 2024
49 checks passed
@lread
Copy link
Collaborator

lread commented Aug 22, 2024

Oh. This did not close 637. Ah. The syntax that GitHub recognizes for Closes/Fixes etc is here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Will close #637

@dgr
Copy link
Contributor Author

dgr commented Aug 22, 2024

Sorry about that. Thanks.

@lread
Copy link
Collaborator

lread commented Aug 22, 2024

No problem at all, @dgr! Thanks for your continued interest and contributions to Etaoin!

@dgr dgr deleted the dgr-issue-637-fill-human-docstrings branch August 22, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants