Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver-type #643

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Add driver-type #643

merged 5 commits into from
Aug 22, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Aug 22, 2024

Closes #642

Please complete and include the following checklist:

  • [x ] I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • [x ] This PR contains test(s) to protect against future regressions

  • [x ] I have updated CHANGELOG.adoc with a description of the addressed issue.

Adds a function named `driver-type` that returns the keyword
appropriate for the specified `driver`.
@dgr dgr changed the title Dgr issue 642 driver type Add driver-type Aug 22, 2024
Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgr, just one review comment!

src/etaoin/api.clj Show resolved Hide resolved
@lread lread merged commit 602e0ec into clj-commons:master Aug 22, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-642-driver-type branch August 23, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add driver-type
2 participants