Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill-human-multi #684

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Oct 8, 2024

Closes #682

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address. Not yet, but it's a bug fix.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

Incorrectly used `fill` rather than `fill-human` in the implementation
and didn't pass the options either.
Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lread lread merged commit eb0c0ad into clj-commons:master Oct 8, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-682-fill-human-multi branch October 9, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fill-human-multi vector case incorrectly uses fill underneath, not fill-human
2 participants