Skip to content

Fix protocol fn DCE issue #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

Fix protocol fn DCE issue #252

merged 3 commits into from
Jun 6, 2025

Conversation

swannodette
Copy link
Member

@swannodette swannodette commented Jun 5, 2025 •
edited
Loading

  • avoid cljs.core/str invoke in protocol fn emitted code
  • add another trivial dce test w/ a protocol fn to catch regressions

@swannodette
* allow numbers to be optimized wtih calls to str
61829b1 
* fixes invoke to cljs.core/str in protocol fns
* add another trivial dce test w/ a protocol fn
@swannodette
Merge remote-tracking branch 'origin/master' into prims-dce
7464b4d
@swannodette
* revert str change
3aa7dce 
* just avoid call to str altogether
@swannodette swannodette changed the title Fix protocol fn DCE issue / allow numbers to printed via the fast path Fix protocol fn DCE issue Jun 5, 2025
@swannodette swannodette merged commit 4d13556 into master Jun 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swannodette