Skip to content

cljs.proxy doesn't handle for .. of correctly #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swannodette merged 3 commits into from
Nov 30, 2025
Merged

cljs.proxy doesn't handle for .. of correctly #298

swannodette merged 3 commits into from
Nov 30, 2025
+28 −5

Conversation

@swannodette
Copy link
Member

@swannodette swannodette commented Nov 30, 2025

  • check for Symbol.iterator case in vec and map handler
  • need to bind iterator to target for it to work
  • fixes trivial vector case [1 2 3 4], but not nested case
    • will need to map over the results of the iterator
    • this true for the map case too where entries are 2-element arrays

@swannodette
cljs.proxy doesn't handle for .. in correctly
d270939 
- check for Symbol.iterator case in vec and map handler
- need to bind iterator to target for it to work
- fixes trivial vector case [1 2 3 4], but not nested case
  * will need to map over the results of the iterator
  * this true for the map case too where entries are 2-element
    arrays
@swannodette
iterator bind case missing from map proxy
7c4c3f3
@swannodette
- add cljs.proxu.impl/MapIterator
3789897 
- remove string cases
- remove iterator cases from map-handler, no for..of for raw Objects
@swannodette swannodette changed the title cljs.proxy doesn't handle for .. in correctly cljs.proxy doesn't handle for .. of correctly Nov 30, 2025
@swannodette swannodette merged commit 9a55107 into master Nov 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swannodette