Change icon for region stat #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seokho Son <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR changes the statistics card to display regions instead of MCIs, updating both the icon and functionality to show unique regions from VMs and Kubernetes clusters.
- Replaces MCI count with region count calculation in the dashboard statistics
- Updates the HTML to use a globe icon and "Regions in Use" label instead of server icon and "Total MCIs"
- Implements logic to extract and count unique regions from both VM and K8s cluster data sources
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dashboard.js | Adds region counting logic that extracts unique regions from VMs and K8s clusters, replacing the previous MCI count display |
| dashboard.html | Updates the statistics card to show region information with a globe icon and appropriate onclick handler |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+1346
to
+1381
| vmData.forEach(vm => { | ||
| let region = null; | ||
|
|
||
| // Extract region information - try multiple sources | ||
| if (vm.region && vm.region.Region) { | ||
| region = vm.region.Region; | ||
| } else if (vm.location && vm.location.region) { | ||
| region = vm.location.region; | ||
| } else if (vm.connectionConfig && vm.connectionConfig.regionZoneInfo && vm.connectionConfig.regionZoneInfo.region) { | ||
| region = vm.connectionConfig.regionZoneInfo.region; | ||
| } else if (vm.regionZoneInfoList && vm.regionZoneInfoList.length > 0 && vm.regionZoneInfoList[0].regionName) { | ||
| region = vm.regionZoneInfoList[0].regionName; | ||
| } | ||
|
|
||
| if (region) { | ||
| regions.add(region); | ||
| } | ||
| }); | ||
|
|
||
| // Add regions from K8s clusters | ||
| k8sData.forEach(cluster => { | ||
| let region = null; | ||
|
|
||
| // Extract region information from cluster | ||
| if (cluster.region && cluster.region.Region) { | ||
| region = cluster.region.Region; | ||
| } else if (cluster.location && cluster.location.region) { | ||
| region = cluster.location.region; | ||
| } else if (cluster.connectionConfig && cluster.connectionConfig.regionZoneInfo && cluster.connectionConfig.regionZoneInfo.region) { | ||
| region = cluster.connectionConfig.regionZoneInfo.region; | ||
| } | ||
|
|
||
| if (region) { | ||
| regions.add(region); | ||
| } | ||
| }); |
There was a problem hiding this comment.
The region extraction logic is duplicated between VM and K8s cluster processing. Consider extracting this into a reusable function to reduce code duplication and improve maintainability.
Copilot uses AI. Check for mistakes.
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.