Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cost estimate api #18

Merged
merged 10 commits into from
Oct 30, 2024
Merged

update cost estimate api #18

merged 10 commits into from
Oct 30, 2024

Conversation

hippo-an
Copy link
Contributor

@hippo-an hippo-an commented Oct 30, 2024

  • log formatting with zero log
  • cost estimate api endpoint update
  • cost estimate api handler and logic update
  • add api for forecast cost update in raw
  • update filtering for instance type when update estimate cost

@MZC-CSC MZC-CSC merged commit 61d19d5 into cloud-barista:main Oct 30, 2024
2 checks passed
@yunkon-kim
Copy link
Member

@hippo-an Zerolog pkg 적용 필요하시려나요? :-)

@hippo-an
Copy link
Contributor Author

@hippo-an Zerolog pkg 적용 필요하시려나요? :-)

모든 코드에 zerolog 를 적용하진 않았지만 모든 코드에 적용하기 위해 입맛에 맞게 구성했습니다. (미들웨어, format)
통일 된 방식의 format 과 로깅 처리가 가능한 패키지가 있다면 적용을 고려해도 괜찮을 것 같습니다.

@yunkon-kim
Copy link
Member

@hippo-an

미들웨어는 동일한 것을 사용하고 계셔서 이슈 없을 것 같고요.

공유해주신 format과 패키징해둔 logger의 format간에는 차이가 있네요.
하지만, Zerolog의 pretty logging 적용해 두셔서 조금만 튜닝하면 적용하는데 어려움은 없을 것 같습니다 :-)

향후 logger를 개선하실 무렵에 잠깐 이야기 나누면 될 것 같습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants