api: rest: Write to database first

cloud-barista · Oct 27, 2024 · 7207d47 · 7207d47
1 parent 5795d85
commit 7207d47
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/pkg/api/rest/controller/software.go b/pkg/api/rest/controller/software.go
@@ -162,16 +162,17 @@ func RegisterSoftware(c echo.Context) error {
 		NeededPackages: neededPackages,
 	}
 
-	destDir := filepath.Join(config.CMGrasshopperConfig.CMGrasshopper.Ansible.PlaybookRootPath, sw.ID)
-	err = writePlaybookFiles(softwareRegisterReq.Name, destDir, softwareRegisterReq.NeededPackages)
+	dbSW, err := dao.SoftwareCreate(&sw)
 	if err != nil {
-		_ = fileutil.DeleteDir(destDir)
-
 		return common.ReturnErrorMsg(c, err.Error())
 	}
 
-	dbSW, err := dao.SoftwareCreate(&sw)
+	destDir := filepath.Join(config.CMGrasshopperConfig.CMGrasshopper.Ansible.PlaybookRootPath, sw.ID)
+	err = writePlaybookFiles(softwareRegisterReq.Name, destDir, softwareRegisterReq.NeededPackages)
 	if err != nil {
+		_ = fileutil.DeleteDir(destDir)
+		_ = dao.SoftwareDelete(&sw)
+
 		return common.ReturnErrorMsg(c, err.Error())
 	}