Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui-storagebrowser] fixes the navigation when sidebar icon is clicked #3998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • When the sidebar icon of the new storage browser is clicked, due to caching, the page does not unmounts and re-mounts, resulting user seeing the last opened directory or file.

How was this patch tested?

  • Manually tested

Please review Hue Contributing Guide before opening a pull request.

@ramprasadagarwal ramprasadagarwal self-assigned this Feb 12, 2025
@ramprasadagarwal ramprasadagarwal requested review from bjornalm, JohanAhlen and tabraiz12 and removed request for bjornalm February 13, 2025 07:31
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. The question is, does a user actually want to lose the state? When switching between apps in Hue I would consider remembering state a feature. If a user want to restart from his/hers home directory it is just one additional click away right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants