[ui-storagebrowser] converts snakecase keys to camel in useLoadData hook #4011
Conversation
ramprasadagarwal
requested review from
JohanAhlen,
tabraiz12,
bjornalm,
Harshg999 and
nidhibhatg
| /> | ||
| {logsData && (logsData.logs.length === 0 || logsData.logs[0] === '') && ( | ||
| {data && (data.logs.length === 0 || data.logs[0] === '') && ( |
There was a problem hiding this comment.
nit: I know that this was not part of the changes, but can't it be that the firs line is an empty line (i.e. data.logs[0] === '') and there are still lines content after that?
There was a problem hiding this comment.
Great catch, it does make lot of sense.
I am checking the old implementation and also with Ananya, Will share the findings soon.
| @@ -35,7 +35,7 @@ import ConfigureIcon from '@cloudera/cuix-core/icons/react/ConfigureIcon'; | |||
| import { i18nReact } from '../../../../utils/i18nReact'; | |||
| import huePubSub from '../../../../utils/huePubSub'; | |||
| import './StorageBrowserActions.scss'; | |||
| import { FileStats, FileSystem, StorageDirectoryTableData } from '../../types'; | |||
| import { FileStats, HDFSFileSystemConfig, StorageDirectoryTableData } from '../../types'; | |||
There was a problem hiding this comment.
What about S3, Azure, Ozone etc fileSystemConfig? Will each have its own config type?
There was a problem hiding this comment.
For now, we have config only for HDFS file system.
And, the keys of the config were very specific to HDFS like isHdfsSuperuser. So, I gave the interface the HDFS specific name for now, Will extend or refactor as the config structure grows in future.
In my understanding, config will be different for each file system (this is a assumption with my current knowledge).
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.