[core] Apply hue conf dir and user/group config to gunicorn options #4158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the gunicorn launch command to respect a new HUE_RUN_DIR environment variable for temporary worker directories, and to conditionally apply Hue’s configured user/group only when GUNICORN_USE_OS_USER is unset. It also refactors the gunicorn config to pull user, group, and worker_tmp_dir from the local options dict.
- Add
HUE_RUN_DIRlookup before falling back toHUE_CONF_DIRor/tmp - Only set
options['user']/['group']whenGUNICORN_USE_OS_USERis not defined - Replace direct
conf.SERVER_USER/SERVER_GROUPcalls in gunicorn config withoptions.get(...)
Comments suppressed due to low confidence (3)
desktop/core/src/desktop/management/commands/rungunicornserver.py:198
- Consider adding automated tests to verify behavior when
GUNICORN_USE_OS_USERis set versus unset, as well as tests for theworker_tmp_dirresolution across the three fallbacks.
if not os.environ.get("GUNICORN_USE_OS_USER"):
desktop/core/src/desktop/management/commands/rungunicornserver.py:189
- [nitpick] It may be helpful to update the module docstring or contributing guide to document the new
HUE_RUN_DIRandGUNICORN_USE_OS_USERenvironment variables so users know how to override defaults.
worker_tmp_dir = os.environ.get("HUE_RUN_DIR")
desktop/core/src/desktop/management/commands/rungunicornserver.py:189
- [nitpick] The nested fallback logic for
worker_tmp_dircould be simplified into a single call toos.environ.getwith defaults, e.g.:os.environ.get('HUE_RUN_DIR', os.environ.get('HUE_CONF_DIR', get_desktop_root('conf') or '/tmp'))to reduce indentation and improve readability.
worker_tmp_dir = os.environ.get("HUE_RUN_DIR")
UI Coverage Report
|
amitsrivastava
approved these changes
Jun 3, 2025
Python Coverage Report •
Pytest Report
|
Harshg999
approved these changes
Jun 4, 2025
| @@ -184,10 +184,21 @@ def argprocessing(args=[], options={}): | |||
| # Currently gunicorn does not support passphrase suppored SSL Keyfile | |||
| # https://github.com/benoitc/gunicorn/issues/2410 | |||
| ssl_keyfile = None | |||
| worker_tmp_dir = os.environ.get("HUE_CONF_DIR", get_desktop_root("conf")) | |||
|
|
|||
| # HUE_RUN_DIR is set for CDW pods. If unset, fall back to previous behaviour (for base). | |||
There was a problem hiding this comment.
Nit: Fix or remove comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Apply hue conf dir and user/group config to gunicorn options
How was this patch tested?
Manual test
Please review Hue Contributing Guide before opening a pull request.