Review feedback applied

Signed-off-by: philthoennissen <[email protected]>
cloudeteer · Oct 15, 2024 · 1663852 · 1663852
1 parent 3cbc6f3
commit 1663852
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -24,7 +24,7 @@ This example demonstrates the usage of the launch-pad module with default settin
 ```hcl
 resource "azurerm_resource_group" "example" {
   location = "germanywestcentral"
-  name     = "example-resource-group"
+  name     = "rg-example-dev-gwc-01"
 }
 
 resource "azurerm_virtual_network" "example" {

diff --git a/r-network.tf b/r-network.tf
@@ -5,7 +5,6 @@ resource "azurerm_virtual_network" "this" {
   tags                = var.tags
 
   address_space = var.virtual_network_address_space
-  # dns_servers   = ["10.0.0.1", "10.0.0.1"]
 }
 
 

diff --git a/tests/remote/resources.tf b/tests/remote/resources.tf
@@ -6,8 +6,14 @@ variable "resource_group_name" {
   type = string
 }
 
+resource "random_string" "resource_group_suffix" {
+  length  = 4
+  special = false
+  upper   = false
+}
+
 resource "azurerm_resource_group" "tftest" {
-  name     = var.resource_group_name
+  name     = "${var.resource_group_name}-${random_string.resource_group_suffix.result}"
   location = var.location
 }