Add Configurable Inputs and Outputs to Enhance Flexibility #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]>
- `key_vault_private_endpoint_private_ip_address` - `network_security_group_id` - `network_security_group_name` Signed-off-by: Roman Schwarz <[email protected]>
Ensures that when name_suffix is not set, the resource name does not end with a trailing -. Signed-off-by: Roman Schwarz <[email protected]>
rswrz
force-pushed
the
4-add-missing-inputs-and-outputs-to-module-for-enhanced-flexibility-and-functionality
branch
from
68055fb
to
a244751
Compare
rswrz
added
enhancement
lixhunter
approved these changes
Nov 15, 2024
rswrz
deleted the
4-add-missing-inputs-and-outputs-to-module-for-enhanced-flexibility-and-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the changes requested in issue #4. It introduces the following updates:
Inputs
nameinput to customize the base name of resources, allowing for easier migration and alignment with best practices.dns_serversinput to configure the DNS servers for the virtual network as per theazurerm_virtual_networkdocumentation.name_suffixinput to allow further customization of resource names.Outputs
network_security_group_idoutput for use with resources likeazurerm_network_watcher_flow_log.network_security_group_nameoutput for use with resources likeazurerm_network_security_rule.private_ip_addressoutput for private endpoints, enabling use in resources likeazurerm_network_security_rule.These changes enhance the module's configurability and align it with common practices, improving its flexibility for various use cases.