This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Bump undici library from 5.28.3 to 5.28.4 #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
italopiresshopify
changed the title
|
@mrbbot Could you please merge this fix? |
RamIdeas
approved these changes
Aug 29, 2024
better-sqlite3 does not build on v22
|
It seems better-sqlite3 (a native dependency) does not compile on node v22 I have changed the github actions workflow to use v20 instead of "latest" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to resolve:
Undici's fetch with integrity option is too lax when algorithm is specified but hash value is in incorrect
Impact
If an attacker can alter the integrity option passed to fetch(), they can let fetch() accept requests as valid even if they have been tampered.
References
https://hackerone.com/reports/2377760