-
Notifications
You must be signed in to change notification settings - Fork 27
Multi Relay Communication with Coordinator #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itzmanish
wants to merge
10
commits into
cloudflare:main
Choose a base branch
from
itzmanish:feat/multi-relay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
02b232a
refactor: restructure relay into lib/bin and add coordinator interface
itzmanish 492309a
feat: add file-based coordinator and rewrote remote for handling remo…
itzmanish 767097f
refactor: simplify QUIC config initialization using new Config::new c…
itzmanish 02bf324
fix: return clients on lookup for coordinator and misc fix
itzmanish 9d4e76d
docs: clarify coordinator file usage in CLI help text and add FIXME f…
itzmanish 838b5ce
fix: add lifetime parameter to lookup method signature for proper bor…
itzmanish 9b91003
fix: prevent file truncation when opening for read/write in FileCoord…
itzmanish ecc63ee
refactor: remove track registration from coordinator interface and fi…
itzmanish f690c31
fix: update lookup signature to return owned Client instead of reference
itzmanish 395ef6a
style: format track namespace test by removing unnecessary line breaks
itzmanish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool - this appears to accomplish the same things I did in this PR: #111
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Sorry I noticed this later after doing the PR. But yeah this now covers for dns resolution by considering address family. Also I am planning to pass custom dns resolution logic in a seperate PR later.