Skip to content
This repository was archived by the owner on Sep 29, 2025. It is now read-only.

Conversation

@simmbiote
Copy link

@simmbiote simmbiote commented May 24, 2024

Suggested fix for issue #792, where // exists in this.path, causing an exception to break the page.


fixes #792

Suggested fix for issue cloudflare#792, where `//` exists in this.path, causing an exception to break the page.
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: 06b8c1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

}

// Prevent `//` in path names.
this.path = this.path.replace(/\/\//g, '/')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is ok as // is always ok to squash to / 🤔

but I think it'd be great to investigate this further and understanding why we end up with // 🤔

I'm guessing that we're doing something wrong earlier during the request handling process

I'm happy to investigate this and or @simmbiote please let me know if you'd like to 🙂

@dario-piotrowicz
Copy link
Member

Thank you very much for the PR (and sorry for the late reply here 🙇).

Earlier this year we released our Cloudflare adapter for OpenNext, and we have been continuously investing effort in its improvement since then. The Cloudflare adapter for OpenNext is currently stable and recommended for deployment of Next.js applications to Cloudflare. As such, we will no longer be maintaining next-on-pages. We recently deprecated the package on npm and we plan to archive this repo on Monday Sep 29, 2025. In preparation for archival, we are closing all open issues and PRs.

If you have concerns, please feel free to reply here before the repo is archived (after that, it will no longer be possible to comment) or to reach out to our team on Discord.

Thank you so much for using and contributing to next-on-pages 🧡

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: "Invalid URL String" error

2 participants