Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let no-unsupported-configs rule check in next.config.ts #896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const ruleSchema = {
const rule: Rule.RuleModule = {
create: context => {
const code = context.sourceCode;
const exportedConfigName = context.filename.match(/next\.config\.m?js$/)
const exportedConfigName = context.filename.match(/next\.config\.(js|cjs|mjs|ts|cts|mts)$/)
? getConfigVariableName(code)
: null;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -497,4 +497,38 @@ describe('no-unsupported-configs', () => {
],
});
});

test('should work with .ts config file extension', () => {
tester.run('', rule, {
valid: [
{
filename: 'next.config.ts',
code: `
const nextConfig = {
}

export default nextConfig;
`,
},
],
invalid: [
{
filename: 'next.config.ts',
code: `
const nextConfig = {
compress: true,
}

export default nextConfig;
`,
errors: [
{
message:
'The "compress" configuration is not supported by next-on-pages (and is unlikely to be supported in the future).',
},
],
},
],
});
});
});