Skip to content

Fix query/cost join matches #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Fix query/cost join matches #1460

merged 1 commit into from
Jun 12, 2025

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.74.0-3-g3f137db9
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (2c37a91) to head (3f137db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1460   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         106      106           
  Lines       14859    14879   +20     
=======================================
+ Hits        14316    14336   +20     
  Misses        403      403           
  Partials      140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
             │   old.txt    │              new.txt               │
             │    sec/op    │    sec/op     vs base              │
GlobFinder-4   30.11m ± ∞ ¹   30.07m ± ∞ ¹       ~ (p=0.690 n=5)
GitFinder-4    386.3m ± ∞ ¹   379.7m ± ∞ ¹  -1.71% (p=0.008 n=5)
CheckRules-4    9.517 ± ∞ ¹    9.507 ± ∞ ¹       ~ (p=1.000 n=5)
geomean        480.2m         477.0m        -0.66%
¹ need >= 6 samples for confidence interval at level 0.95

             │    old.txt    │               new.txt               │
             │     B/op      │     B/op       vs base              │
GlobFinder-4   9.495Mi ± ∞ ¹   9.494Mi ± ∞ ¹       ~ (p=0.095 n=5)
GitFinder-4    19.56Mi ± ∞ ¹   19.57Mi ± ∞ ¹       ~ (p=0.841 n=5)
CheckRules-4   1.106Gi ± ∞ ¹   1.105Gi ± ∞ ¹       ~ (p=0.421 n=5)
geomean        59.48Mi         59.46Mi        -0.04%
¹ need >= 6 samples for confidence interval at level 0.95

             │   old.txt    │              new.txt               │
             │  allocs/op   │  allocs/op    vs base              │
GlobFinder-4   145.2k ± ∞ ¹   145.2k ± ∞ ¹       ~ (p=0.087 n=5)
GitFinder-4    191.6k ± ∞ ¹   191.6k ± ∞ ¹       ~ (p=0.643 n=5)
CheckRules-4   16.26M ± ∞ ¹   16.25M ± ∞ ¹       ~ (p=0.310 n=5)
geomean        767.7k         767.5k        -0.02%
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt    │            new.txt            │
        │    sec/op    │    sec/op     vs base         │
Parse-4   23.99m ± ∞ ¹   23.44m ± ∞ ¹  ~ (p=0.151 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │    old.txt    │            new.txt             │
        │     B/op      │     B/op       vs base         │
Parse-4   7.308Mi ± ∞ ¹   7.308Mi ± ∞ ¹  ~ (p=0.690 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

        │   old.txt    │            new.txt            │
        │  allocs/op   │  allocs/op    vs base         │
Parse-4   125.7k ± ∞ ¹   125.7k ± ∞ ¹  ~ (p=0.762 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt    │              new.txt               │
                    │    sec/op    │    sec/op     vs base              │
QueryCacheOnlySet-4   103.2n ± ∞ ¹   103.0n ± ∞ ¹       ~ (p=0.143 n=5)
QueryCacheSetGrow-4   392.4n ± ∞ ¹   398.8n ± ∞ ¹       ~ (p=0.690 n=5)
QueryCacheGetMiss-4   16.76n ± ∞ ¹   16.94n ± ∞ ¹  +1.07% (p=0.008 n=5)
QueryCacheGC-4        56.22µ ± ∞ ¹   55.34µ ± ∞ ¹       ~ (p=0.095 n=5)
QueryCacheGCNoop-4    84.15µ ± ∞ ¹   82.29µ ± ∞ ¹  -2.21% (p=0.008 n=5)
geomean               1.263µ         1.259µ        -0.26%
¹ need >= 6 samples for confidence interval at level 0.95

                    │    old.txt    │                new.txt                │
                    │     B/op      │     B/op       vs base                │
QueryCacheOnlySet-4     64.00 ± ∞ ¹     64.00 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4     121.0 ± ∞ ¹     136.0 ± ∞ ¹       ~ (p=0.103 n=5)
QueryCacheGetMiss-4     0.000 ± ∞ ¹     0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC-4        36.13Ki ± ∞ ¹   36.13Ki ± ∞ ¹       ~ (p=1.000 n=5)
QueryCacheGCNoop-4    54.17Ki ± ∞ ¹   54.17Ki ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                           ³                  +2.36%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                    │   old.txt   │               new.txt               │
                    │  allocs/op  │  allocs/op   vs base                │
QueryCacheOnlySet-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheSetGrow-4   1.000 ± ∞ ¹   1.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGetMiss-4   0.000 ± ∞ ¹   0.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGC-4        6.000 ± ∞ ¹   6.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
QueryCacheGCNoop-4    9.000 ± ∞ ¹   9.000 ± ∞ ¹       ~ (p=1.000 n=5) ²
geomean                         ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

@prymitive prymitive merged commit c56d766 into main Jun 12, 2025
21 checks passed
@prymitive prymitive deleted the query branch June 12, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants