add qlog event definitions for Careful Resume #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPardue
reviewed
Aug 22, 2025
| @@ -276,6 +276,10 @@ impl From<EventType> for EventImportance { | |||
| RecoveryEventType::MarkedForRetransmit, | |||
| ) => EventImportance::Extra, | |||
|
|
|||
| EventType::RecoveryEventType( | |||
| RecoveryEventType::CarefulResumePhaseUpdated, | |||
There was a problem hiding this comment.
This isn't strictly a recovery event in qlog terms (although its somewhat complicated by the this crate lagging behind the latest specs.
On balance, I think it would be better to define a different EventType for careful resume. I.e. defining a separate enum in qlog/src/events/quic.rs
qlog/src/events/resume.rs
Outdated
| /// When sender has confirmed the RTT, has received an ACK for the initial | ||
| /// data without reported congestion and has more data to send than the CWND | ||
| /// would allow. | ||
| #[serde(rename = "cwnd_limited")] |
There was a problem hiding this comment.
This doesn't seem to match the name in the spec: https://datatracker.ietf.org/doc/html/draft-ietf-tsvwg-careful-resume-qlog#section-3.3.1
| pub first_unvalidated_packet: u64, | ||
| pub last_unvalidated_packet: u64, | ||
| pub congestion_window: Option<u64>, | ||
| pub ssthresh: Option<u64>, |
There was a problem hiding this comment.
spec says all these are u32, not u64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the qlog event definitions for Careful Resume according to the draft.