Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option for Delegation to Any User #134

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on May 10, 2016

  1. Add delegation option for any user to be able to decrypt

    core: Add AnyUser field to DelegateRequest and pass to cache calls
    
    keycache: Add AnyUser parameter to AddKeyFromRecord function signature
    
    keycache_test: Add tests for AnyUser and update AddKeyFromRecord calls
    
    cryptor: Update tests to AddKeyFromRecord to reflect API update
    
    cmd/ro: Add bool flag for anyUser parameter
    
    Note: This commit was further amended to change the AddKeyFromRecord
    API to accept keycache.Usage as a parameter, which will make updating
    usage simpler in the future.
    Tyler J authored and APTy committed May 10, 2016
    Configuration menu
    Copy the full SHA
    93e7917 View commit details
    Browse the repository at this point in the history
  2. Remove backwards-compatibility for delegating without a list of users

    keycache: Remove deprecated behavior in Usage.matches()
    
    core: Add check during delegation for a User list or the AnyUser flag
    
    tests: Add parameters to conform to new delegation requirements
    Tyler J authored and APTy committed May 10, 2016
    Configuration menu
    Copy the full SHA
    fa16fe5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2016

  1. Add tests in core for success and failure of the AnyUser parameter

    core: Add unit tests scenarios
    
    core: Check for a non-nil, but empty, Users list
    
    keycache: Add unit tests
    Tyler J authored and APTy committed May 11, 2016
    Configuration menu
    Copy the full SHA
    d97f953 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5485b6e View commit details
    Browse the repository at this point in the history
  3. Use keyed fields in composite literal, per vet source report

    Output before change:
    cryptor/cryptor_test.go:112:
    github.com/cloudflare/redoctober/keycache.Usage composite literal uses
    unkeyed fields
    APTy committed May 11, 2016
    Configuration menu
    Copy the full SHA
    263c73a View commit details
    Browse the repository at this point in the history