Fix new clippy lints #138
Merged
Fix new clippy lints #138
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakcutner
reviewed
Jun 26, 2025
Comment on lines
119
to
125
| let mut iter = self.0.iter(); | ||
| let first = iter.next().unwrap(); | ||
| write!(f, "{{{}", first)?; | ||
| write!(f, "{{{first}")?; | ||
| for expected_type in iter { | ||
| write!(f, ", {}", expected_type)?; | ||
| write!(f, ", {expected_type}")?; | ||
| } | ||
| write!(f, "}}") |
There was a problem hiding this comment.
nit: I might be missing something, but I think this whole block can be simplified?
write!(f, "{{")?;
for expected_type in self.0.iter() {
write!(f, ", {expected_type}")?;
}
write!(f, "}}")There was a problem hiding this comment.
But it means the first element would be prefixed by a comma?
There was a problem hiding this comment.
Ah, I missed the comma completely 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.