[Instrumentation] Test to debug CI #5271
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings WO-750 Fixes images test to match expected spans WO-750 Adds tracing.startSpanWithCallback. Adds instrumentation test to D1 WO-750 Changes InternalSpan to hold kj::Maybe<IOOwn<T>> WO-750 Skips initialisation logic if no span in context WO-750 updates d1 instrumentation test. Cleans up some tracing-module code WO-750 Changes from v8::Function to jsg::Function in tracing-module WO-750 changes kj::str() to kj::mv() in few places WO-750 Changes v8::Value to jsg::JsValue in few places WO-750 Styling fix WO-750 Fixes compilation errors
WO-750 kj::str to kj::mv change for setTag invocation WO-750 Removes KJ_UNREACHABLE from setTag
Co-authored-by: Jeremy Morrell (Cloudflare) <[email protected]>
This reverts commit 4bc4bdd.
Co-authored-by: Jeremy Morrell (Cloudflare) <[email protected]>
…multipart boundaries in images tests.
mar-cf
force-pushed
the
maksym/WO-750/0
branch
from
c67104f to
5b29b89
Compare
mar-cf
force-pushed
the
maksym/WO-750/0
branch
from
2421e2e to
371c030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to bisect and figure out what's going wrong in #5218 Ignore this PR