Add routingMode option to GetDurableObjectOptions
#5525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellowYarker
force-pushed
the
milan/direct-to-primary
branch
from
7a08cc7 to
d5a16d4
Compare
|
The generated output of |
CodSpeed Performance ReportMerging #5525 will not alter performanceComparing Summary
Footnotes
|
MellowYarker
force-pushed
the
milan/direct-to-primary
branch
from
d5a16d4 to
a14cc38
Compare
MellowYarker
changed the title
getPrimaryOnly option to GetDurableObjectOptionsroutingMode option to GetDurableObjectOptions
MellowYarker
force-pushed
the
milan/direct-to-primary
branch
3 times, most recently
from
9adef6b to
85c05c0
Compare
Contributor
Author
|
Latest push updates types. Couldn't get |
MellowYarker
force-pushed
the
milan/direct-to-primary
branch
from
85c05c0 to
3289720
Compare
justin-mp
approved these changes
Nov 20, 2025
| // `routingMode` may be be of interest to applications using Durable Objects replicas. It can be | ||
| // one of the following options: | ||
| // - none: the default, indicates we will pick for the application. | ||
| // - "primary-only": guarantees we route directly to the primary (skip any replicas.) |
Contributor
There was a problem hiding this comment.
nit: period outside of parens.
Suggested change
| // - "primary-only": guarantees we route directly to the primary (skip any replicas.) | |
| // - "primary-only": guarantees we route directly to the primary (skip any replicas). |
| JSG_STRUCT(locationHint, routingMode); | ||
|
|
||
| JSG_STRUCT_TS_DEFINE(type DurableObjectLocationHint = "wnam" | "enam" | "sam" | "weur" | "eeur" | "apac" | "oc" | "afr" | "me"); | ||
| // Possible values from https://developers.cloudflare.com/workers/runtime-apis/durable-objects/#providing-a-location-hint |
Contributor
There was a problem hiding this comment.
Given that there are now multiple values in the struct, you may want to say DurableObjectLocationHint values from ...
Suggested change
| // Possible values from https://developers.cloudflare.com/workers/runtime-apis/durable-objects/#providing-a-location-hint | |
| // DurableObjectLocationHint values from https://developers.cloudflare.com/workers/runtime-apis/durable-objects/#providing-a-location-hint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.