[o11y] Additional hardening against missing outcome event, STW optimizations #5527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/110925-stw-2
branch
from
d8a2a9c to
3d6898e
Compare
fhanau
changed the title
fhanau
commented
Nov 20, 2025
| return buffered; | ||
| } | ||
|
|
||
| protected: |
Contributor
Author
There was a problem hiding this comment.
The protected thing here won't be needed once #5519 and the corresponding internal PR have landed.
fhanau
commented
Nov 20, 2025
| auto& tailStreamWriter = KJ_UNWRAP_OR_RETURN(maybeTailStreamWriter); | ||
| // This is where we'll actually encode the span. This function should never be invoked if STW is | ||
| // inactive as span tracing is only used in STW. | ||
| auto& tailStreamWriter = KJ_ASSERT_NONNULL(maybeTailStreamWriter); |
Contributor
Author
There was a problem hiding this comment.
this is intended as additional hardening, using KJ_UNWRAP_OR_RETURN could cause us to miss out on span tracing being set up when it is not being used – I'm highly confident that we're already avoiding this though.
fhanau
commented
Nov 20, 2025
|
|
||
| KJ_IF_SOME(writer, maybeTailStreamWriter) { | ||
| auto& spanContext = KJ_UNWRAP_OR_RETURN(topLevelInvocationSpanContext); | ||
| auto& spanContext = KJ_ASSERT_NONNULL(topLevelInvocationSpanContext); |
Contributor
Author
There was a problem hiding this comment.
This serves as additional hardening too, I'm very confident that we always provide the Onset event when doing tracing.
Contributor
Author
|
Downstream PR is still WIP, but this is ready for review. |
fhanau
force-pushed
the
felix/110925-stw-2
branch
from
3d6898e to
5dc1403
Compare
|
The generated output of |
…zations - Introduce a new WorkerTracer parameter indicating whether any BTWs are present. In a follow-up, this will be used to optimize memory management, but for now it helps us assert that if we have a tracer with logLevel none, we have BTWs (otherwise the tracer would be redundant, indicating waste). - Log an error if a WorkerTracer is destructed without getting the Outcome event even when logLevel == none
fhanau
force-pushed
the
felix/110925-stw-2
branch
from
5dc1403 to
b329282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
present. In a follow-up, this will be used to optimize memory management,
but for now it helps us assert that if we have a tracer with logLevel none,
we have BTWs (otherwise the tracer would be redundant, indicating waste).
even when logLevel == none