Refactor CompressionStreamImpl #5580
Open
+111
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
What type of case? Are you referring to the new |
harrishancock
approved these changes
Nov 28, 2025
| RingBuffer<PendingRead, 8> pendingReads; | ||
| }; | ||
|
|
||
| // Adapter to bridge CompressionStreamImpl (which implements AsyncInputStream snf |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Adapter to bridge CompressionStreamImpl (which implements AsyncInputStream snf | |
| // Adapter to bridge CompressionStreamImpl (which implements AsyncInputStream and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative take on the CompressionStreamImpl refactor. Turns out that the system-streams adapters don't cover this type of case correctly... but this still steps in the right direction