Default --x-registry to on (#7081)

cloudflare · Nov 16, 2024 · b4a0e74 · b4a0e74
1 parent d4d3062
commit b4a0e74
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 4 deletions.
diff --git a/.changeset/tricky-bottles-bow.md b/.changeset/tricky-bottles-bow.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Default the file based registry (`--x-registry`) to on. This should improve stability of multi-worker development
diff --git a/packages/wrangler/e2e/dev-registry.test.ts b/packages/wrangler/e2e/dev-registry.test.ts
@@ -105,6 +105,8 @@ describe("unstable_dev()", () => {
 						}
 					);
 
+					await setTimeout(2000)
+
 					const parentWorker = await unstable_dev(
 						"src/index.ts",
 						{

diff --git a/packages/wrangler/src/__tests__/dev.test.ts b/packages/wrangler/src/__tests__/dev.test.ts
@@ -1419,7 +1419,7 @@ describe.sequential("wrangler dev", () => {
 				      --test-scheduled                             Test scheduled events by visiting /__scheduled in browser  [boolean] [default: false]
 				      --log-level                                  Specify logging level  [choices: \\"debug\\", \\"info\\", \\"log\\", \\"warn\\", \\"error\\", \\"none\\"] [default: \\"log\\"]
 				      --show-interactive-dev-session               Show interactive dev session (defaults to true if the terminal supports interactivity)  [boolean]
-				      --experimental-registry, --x-registry        Use the experimental file based dev registry for multi-worker development  [boolean] [default: false]
+				      --experimental-registry, --x-registry        Use the experimental file based dev registry for multi-worker development  [boolean] [default: true]
 				      --experimental-vectorize-bind-to-prod        Bind to production Vectorize indexes in local development mode  [boolean] [default: false]",
 				  "warn": "",
 				}

diff --git a/packages/wrangler/src/api/dev.ts b/packages/wrangler/src/api/dev.ts
@@ -125,7 +125,7 @@ export async function unstable_dev(
 		showInteractiveDevSession,
 		testMode,
 		testScheduled,
-		fileBasedRegistry = false,
+		fileBasedRegistry = true,
 		vectorizeBindToProd,
 		// 2. options for alpha/beta products/libs
 		d1Databases,

diff --git a/packages/wrangler/src/api/integrations/platform/index.ts b/packages/wrangler/src/api/integrations/platform/index.ts
@@ -110,7 +110,7 @@ export async function getPlatformProxy<
 
 	const miniflareOptions = await run(
 		{
-			FILE_BASED_REGISTRY: Boolean(options.experimentalRegistry),
+			FILE_BASED_REGISTRY: Boolean(options.experimentalRegistry ?? true),
 			JSON_CONFIG_FILE: Boolean(options.experimentalJsonConfig),
 		},
 		() => getMiniflareOptionsFromConfig(rawConfig, env, options)

diff --git a/packages/wrangler/src/dev-registry/file-registry.ts b/packages/wrangler/src/dev-registry/file-registry.ts
@@ -65,6 +65,8 @@ async function devRegistry(
 async function startWorkerRegistry(
 	cb?: (registry: WorkerRegistry | undefined) => void
 ) {
+	await loadWorkerDefinitions();
+	cb?.({ ...globalWorkers });
 	globalWatcher ??= watch(DEV_REGISTRY_PATH, {
 		persistent: true,
 	}).on("all", async () => {

diff --git a/packages/wrangler/src/dev.ts b/packages/wrangler/src/dev.ts
@@ -314,7 +314,7 @@ const command = defineCommand({
 			type: "boolean",
 			describe:
 				"Use the experimental file based dev registry for multi-worker development",
-			default: false,
+			default: true,
 		},
 		"experimental-vectorize-bind-to-prod": {
 			type: "boolean",