getSelectedModels() should only return instances of Backbone.Model#38
Open
prg wants to merge 2 commits intocloudflarearchive:masterfrom
Open
getSelectedModels() should only return instances of Backbone.Model#38prg wants to merge 2 commits intocloudflarearchive:masterfrom
prg wants to merge 2 commits intocloudflarearchive:masterfrom
Conversation
- without this, getSelectedModels() return value would sometimes contain 'undefined' values; e.g. with server-side paging
- event handlers for "backgrid:selected" are sometimes called in the wrong order; e.g. checking the select box in a newly added row calls the custom handler first, before the selection is updated, which in turn breaks getSelectedModels().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should alleviate some of the problems people are seeing (e.g. #3, #13, #14). Haven't gone through these issues in detail, but it works for my use case (a grid with server-side paging via
Backbone.PageableCollection):getSelectedModels()returns only selected models from the current page