Skip to content

Comments

Make internal cc dns name configurable#1844

Open
c0d1ngm0nk3y wants to merge 1 commit intocloudfoundry:developfrom
sap-contributions:configure-internal-address
Open

Make internal cc dns name configurable#1844
c0d1ngm0nk3y wants to merge 1 commit intocloudfoundry:developfrom
sap-contributions:configure-internal-address

Conversation

@c0d1ngm0nk3y
Copy link
Contributor

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Make the reference to the internal address of the cloudcontroller (cloud-controller-ng.service.cf.internal) configurable. This makes it possible to reuse the ASG test if you have another internal domain (e.g. kind)

Please provide contextual information.

Enable for include_security_groups kind. The default is the old hardcoded value, so no user has to change anything.

What version of cf-deployment have you run this cf-acceptance-test change against?

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

0

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

@nicolasbender @modulo11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants