[main] Multiple commands changed to allow canary steps #3400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
2 times, most recently
from
c4d08a4 to
cd7cf35
Compare
a-b
reviewed
Feb 12, 2025
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
2 times, most recently
from
92fed62 to
e9f6fe6
Compare
joaopapereira
changed the title
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
from
e9f6fe6 to
3e027ae
Compare
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
from
3e027ae to
42cb1fe
Compare
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Samze
approved these changes
Mar 26, 2025
Samze
added a commit
that referenced
this pull request
Apr 9, 2025
* Fix error message for push command Signed-off-by: João Pereira <[email protected]> * Display current step in the canary deployment Signed-off-by: João Pereira <[email protected]> * Add --instance-steps to the restart command Signed-off-by: João Pereira <[email protected]> * Add flag --instance-steps to restage command Signed-off-by: João Pereira <[email protected]> * Add --instance-steps to rollback Signed-off-by: João Pereira <[email protected]> * Add --instance-steps to copy-source command Signed-off-by: João Pereira <[email protected]> * Fix rollback that was not setting the correct values on the deployment Signed-off-by: João Pereira <[email protected]> * Add min capi version check on instance steps commands Signed-off-by: João Pereira <[email protected]> * Fix pointer reference * Add version to copy-source canary step test * Update canary step version requirement * Fix continue deployment test * Fix CAPI versions in tests * Fixes for canary integration tests * Fix flakey canary test * Add missing continue to copy-source canary test --------- Signed-off-by: João Pereira <[email protected]> Co-authored-by: Sam Gunaratne <[email protected]> Co-authored-by: Sam Gunaratne <[email protected]>
Samze
added a commit
that referenced
this pull request
Apr 9, 2025
* [main] Multiple commands changed to allow canary steps (#3400) * Fix error message for push command Signed-off-by: João Pereira <[email protected]> * Display current step in the canary deployment Signed-off-by: João Pereira <[email protected]> * Add --instance-steps to the restart command Signed-off-by: João Pereira <[email protected]> * Add flag --instance-steps to restage command Signed-off-by: João Pereira <[email protected]> * Add --instance-steps to rollback Signed-off-by: João Pereira <[email protected]> * Add --instance-steps to copy-source command Signed-off-by: João Pereira <[email protected]> * Fix rollback that was not setting the correct values on the deployment Signed-off-by: João Pereira <[email protected]> * Add min capi version check on instance steps commands Signed-off-by: João Pereira <[email protected]> * Fix pointer reference * Add version to copy-source canary step test * Update canary step version requirement * Fix continue deployment test * Fix CAPI versions in tests * Fixes for canary integration tests * Fix flakey canary test * Add missing continue to copy-source canary test --------- Signed-off-by: João Pereira <[email protected]> Co-authored-by: Sam Gunaratne <[email protected]> Co-authored-by: Sam Gunaratne <[email protected]> * Update min versions --------- Signed-off-by: João Pereira <[email protected]> Co-authored-by: João Pereira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add
--instance-stepsto the restart, restage, rollback command