Skip to content

Comments

CLOS-3468: Add support for upgrades cl8 -> cl9 with cl-mysql#38

Merged
prilr merged 2 commits intocloudlinuxfrom
clos-3468-add-cl-mysql-support-cl8
Jul 30, 2025
Merged

CLOS-3468: Add support for upgrades cl8 -> cl9 with cl-mysql#38
prilr merged 2 commits intocloudlinuxfrom
clos-3468-add-cl-mysql-support-cl8

Conversation

@Monstrofil
Copy link
Collaborator

@Monstrofil Monstrofil commented Jul 28, 2025

This PR adds support for cl-mysql and cl-mariadb upgrades during elevation from CloudLinux 8 to CloudLinux 9.

@Monstrofil
CLOS-3468: Add support for upgrades cl8 -> cl9 with cl-mysql
da14b8f 
Replace hardcoded "7" and "8" in the actor code with
dynamically detected get_source_major_version which makes
code work both with CloudLinux 8 and CloudLinux 9 upgrades.
@github-actions
Copy link

github-actions bot commented Jul 28, 2025

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

  • review please @oamg/developers to notify leapp developers of the review request
  • /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

  • /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
  • /packit test --labels beaker-minimal-8.9to9.3,kernel-rt-8.9to9.3 to schedule kernel-rt and beaker-minimal test sets for 8.9->9.3 upgrade path

[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:

  • /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
  • /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
  • /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
  • /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

azheregelya
azheregelya reviewed Jul 29, 2025
View reviewed changes
.../system_upgrade/cloudlinux/actors/clmysqlrepositorysetup/libraries/clmysqlrepositorysetup.py
target_repo.repoid = "{}-{}".format(target_repo.repoid, target_major)
# Replace the first occurrence of source_major with target_major after 'yum'
url_parts = target_repo.baseurl.split("yum", 1)
if len(url_parts) == 2:
Copy link

@azheregelya azheregelya Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we report an error or a warning message here if split didn't go as expected? For example, in case of URL change.

@prilr prilr merged commit 1eb4fe1 into cloudlinux Jul 30, 2025
@prilr prilr deleted the clos-3468-add-cl-mysql-support-cl8 branch July 30, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@azheregelya azheregelya azheregelya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Monstrofil @azheregelya @prilr