Skip to content

Add retries when rate-limited, improve performance #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 12, 2025
Merged

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 11, 2025

what

  • Add throttling to overall GitHub Issue API call rate
  • Add automatic retries when rate limited
  • Await async calls to update issues
  • Update dependencies to current
  • Switch to ncc-bundled action: main now points to dist/index.js, node_modules removed

why

  • Large numbers of issues can trigger secondary API rate limiting at GitHub
  • Rate limiting is dynamic, no guarantee our throttling will be completely sufficient
  • Ensure promises resolve properly, fixing long wait at end of run
  • Multiple bug fixes and efficiencies
  • Considered best practice

references

  • GitHub Documentation "Create a JavaScript action":

    Checking in your node_modules directory can cause problems. As an alternative, you can use a tool called @vercel/ncc to compile your code and modules into one file used for distribution.

@Nuru Nuru requested review from a team as code owners April 11, 2025 02:05
@Nuru Nuru requested review from hans-d and RoseSecurity April 11, 2025 02:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12669 out of 12671 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • .nvmrc: Language not supported
  • Makefile: Language not supported

@cloudpossebot
Copy link
Member

Important

No Changes Were Applied

This Pull Request was merged without using the auto-apply label; therefore, no changes were applied upon merging.

Review the associated issues and, if applicable, tag each with the apply label to apply the changes.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12669 out of 12671 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • .nvmrc: Language not supported
  • Makefile: Language not supported

@Nuru Nuru requested a review from milldr April 11, 2025 02:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12675 out of 12677 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • .nvmrc: Language not supported
  • Makefile: Language not supported

@Nuru Nuru merged commit cac7f38 into main Apr 12, 2025
22 checks passed
@Nuru Nuru deleted the rate-limit-retry branch April 12, 2025 18:20
@Nuru Nuru restored the rate-limit-retry branch April 12, 2025 18:20
Copy link

These changes were released in v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants