Skip to content

Commit

Permalink
Fixes #134 - Skips http_forward when aws_lb_target_group.default is d…
Browse files Browse the repository at this point in the history
…isabled

* disables aws_lb_listener.http_forward when default_target_group is not enabled
* target_group is required when type is 'redirect'

Fixes this Validation error when default_target_group_enabled == 0 :

```
module.alb.aws_lb_listener.http_forward[0]: Creating...
╷
│ Error: creating ELBv2 Listener
(arn:aws:elasticloadbalancing:...:...:loadbalancer/...):
ValidationError: A target group ARN must be specified
│       status code: 400, request id:
7cf9d727-fc77-4d32-a160-cbd175e16e20
│
│   with module.alb.aws_lb_listener.http_forward[0],
│   on .terraform/modules/alb/main.tf line 150, in resource
"aws_lb_listener" "http_forward":
│  150: resource "aws_lb_listener" "http_forward" {

```
  • Loading branch information
spazm committed Nov 2, 2023
1 parent fb4ec8e commit d1a69cb
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,20 @@ resource "aws_lb_target_group" "default" {
resource "aws_lb_listener" "http_forward" {
#bridgecrew:skip=BC_AWS_GENERAL_43 - Skipping Ensure that load balancer is using TLS 1.2.
#bridgecrew:skip=BC_AWS_NETWORKING_29 - Skipping Ensure ALB Protocol is HTTPS
count = module.this.enabled && var.http_enabled && var.http_redirect != true ? 1 : 0
count = (
module.this.enabled &&
var.http_enabled &&
var.http_redirect != true &&
(var.listener_http_fixed_response != null || var.default_target_group_enabled)
? 1 : 0
)
load_balancer_arn = one(aws_lb.default[*].arn)
port = var.http_port
protocol = "HTTP"
tags = merge(module.this.tags, var.listener_additional_tags)

default_action {
# target_group_arn is required when type is forward
target_group_arn = var.listener_http_fixed_response != null ? null : one(aws_lb_target_group.default[*].arn)
type = var.listener_http_fixed_response != null ? "fixed-response" : "forward"

Expand Down

0 comments on commit d1a69cb

Please sign in to comment.