Skip to content

Allow using multiple cors origins #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuekui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow using multiple cors origins #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,15 +354,14 @@ resource "aws_s3_bucket_cors_configuration" "origin" {

bucket = one(aws_s3_bucket.origin).id

dynamic "cors_rule" {
for_each = distinct(compact(concat(var.cors_allowed_origins, var.aliases, var.external_aliases)))
content {
allowed_headers = var.cors_allowed_headers
allowed_methods = var.cors_allowed_methods
allowed_origins = [cors_rule.value]
expose_headers = var.cors_expose_headers
max_age_seconds = var.cors_max_age_seconds
}
cors_rule {
allowed_headers = var.cors_allowed_headers
allowed_methods = var.cors_allowed_methods
allowed_origins = sort(
distinct(compact(concat(var.cors_allowed_origins, var.aliases, var.external_aliases)))
)
expose_headers = var.cors_expose_headers
max_age_seconds = var.cors_max_age_seconds
}

depends_on = [time_sleep.wait_for_aws_s3_bucket_settings]
Expand Down