Support null value in access_log_bucket_name condition #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enabled condition now uses coalesce() to treat null values the same as empty strings, allowing proper logic flow when the variable is not set. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Author
|
/terratest |
coalesce() fails when all arguments are empty strings. Using an explicit check for both null and empty string avoids this error. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Author
|
/terratest |
milldr
approved these changes
Jan 16, 2026
Contributor
|
These changes were released in v0.29.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
coalesce()nullvalues the same as empty stringswhy
var.access_log_bucket_name == ""fails when the variable isnullcoalesce(var.access_log_bucket_name, "")ensures bothnulland""trigger the access log bucket name generation logicreferences