-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Add cloudwatch and security group outputs #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
675c0b1
to
73a844a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes. Running tests to confirm all is good 👍
/terratest |
73a844a
to
2a9130d
Compare
2a9130d
to
72cd5f2
Compare
/terratest |
@adamcrews this is annoying, but can you add descriptions to all of the outputs in
|
72cd5f2
to
20af392
Compare
💥 This pull request now has conflicts. Could you fix it @adamcrews? 🙏 |
20af392
to
69b97f6
Compare
No worries. It looks like these failures pre-date my changes, but I added descriptions to the existing outputs, and added all outputs to the example/complete code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/terratest |
These changes were released in v1.1.0. |
what
This adds the outputs for the optionally created cloudwatch logs and the security group.
why
In my use case, this information is useful to pass on to other modules, thus adding the outputs helps expose that information.
This also supersedes PR #116
and closes issue #91