Add disconnect_on_session_timeout option #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsimon
force-pushed
the
disconnect-timeout
branch
2 times, most recently
from
fc9295c to
0e5f709
Compare
|
I just looked up that this option came in aws provider 5.90.0, adding this to versions.tf. |
vsimon
force-pushed
the
disconnect-timeout
branch
2 times, most recently
from
adfd8c0 to
3724bde
Compare
|
/terratest |
|
@vsimon thanks for your contribution! Could you please run |
vsimon
force-pushed
the
disconnect-timeout
branch
from
3724bde to
fe069eb
Compare
Thanks @gberenice, the format has been run. |
|
/terratest |
|
💥 This pull request now has conflicts. Could you fix it @vsimon? 🙏 |
vsimon
force-pushed
the
disconnect-timeout
branch
from
fe069eb to
a7c121f
Compare
|
This is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
what
This exposes the disconnect_on_session_timeout option
why
To be able to have the client VPN session be disconnected after the maximum session_timeout_hours is reached.
references
#122