Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use for_each over count for iteration #96

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jurgenweber
Copy link

what

moving to for_each for resources over count

why

I lost the ability to update an endpoint for 12 hours because of this. Standard terraform count vs for_each reasons (index changes with count).

references

#30

@jurgenweber jurgenweber requested review from a team as code owners March 22, 2024 00:32
@jurgenweber jurgenweber changed the title issue #30, use for_each over count for iteration use for_each over count for iteration Mar 22, 2024
@mergify mergify bot added the triage Needs triage label Mar 22, 2024
@jurgenweber
Copy link
Author

I am not on top of all of your processes, but this will be a breaking change because as per the issue you will trigger the AWS API problems.

Maybe we want a migration process? Maybe some moves? Let me know.

@joe-niland
Copy link
Member

Hi @jurgenweber thanks for your contribution. Have you tested this code? It seems to have some invalid syntax.

@jurgenweber
Copy link
Author

indeed, sorted now. Plans for me:

Plan: 36 to add, 0 to change, 36 to destroy.

:)

@jurgenweber
Copy link
Author

Any reason this has been put on ice? What do you need from me to get it over the line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants