feat: add identifier prefixes to recreate resources #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
force-pushed
the
identifier_prefix
branch
2 times, most recently
from
3635adb to
7824d5a
Compare
Signed-off-by: nitrocode <[email protected]>
nitrocode
force-pushed
the
identifier_prefix
branch
from
7824d5a to
ae7ec42
Compare
nitrocode
commented
Mar 14, 2025
nitrocode
commented
Mar 14, 2025
nitrocode
commented
Mar 14, 2025
Signed-off-by: nitrocode <[email protected]>
nitrocode
added
minor
|
/terratest |
finchr
reviewed
Mar 14, 2025
| identifier = "${module.rds_identifier[0].id}-${count.index + 1}" | ||
| count = local.cluster_instance_count | ||
|
|
||
| identifier_prefix = var.rds_cluster_identifier_prefix_enabled ? "${module.rds_identifier[0].id}${module.this.delimiter}${count.index + 1}${module.this.delimiter}" : null |
There was a problem hiding this comment.
The unique name for the aws_rds_cluster_instance should be controlled by the random_pet that feeds into the module.rds_identifier. Why is that not working here?
There was a problem hiding this comment.
How do you know it's not working?
There was a problem hiding this comment.
Oh I see what you're saying. The random pet does go into the rds_identifier. Hmm, maybe I'm not using it correctly
There was a problem hiding this comment.
@nitrocode there is some history here, I made some changes in #236 but after some FUD some of the changes were taken out in #242. You would probably need to add cluster_identifier back into the random_pet to get the features you want.
nitrocode
changed the title
Signed-off-by: nitrocode <[email protected]>
nitrocode
force-pushed
the
identifier_prefix
branch
from
a789518 to
a8501c4
Compare
Signed-off-by: nitrocode <[email protected]>
nitrocode
force-pushed
the
identifier_prefix
branch
from
cc1cef1 to
fff6fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
parameter_group_name_prefix_enabledrds_cluster_identifier_prefix_enableddb_subnet_group_prefix_enabled*_prefixarguments add an additional 27 characters to each resource which can cause errors upon apply due to it exceeding 64 characters*_prefixand instead use a random string for each of these resource typesreferences
create_before_destroyset totrueon the cluster instance #257