Skip to content

feat(rds): add database_insights_mode #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RoseSecurity merged 5 commits into from
Dec 11, 2025
Merged

feat(rds): add database_insights_mode #195

RoseSecurity merged 5 commits into from
Dec 11, 2025

Conversation

@cdobbyn
Copy link
Contributor

@cdobbyn cdobbyn commented May 30, 2025 •
edited
Loading

what

  • Add database_insights_mode.
  • Bump aws provider version requirement to >= 5.92.0

why

  • AWS is asking customers to migrate from the rds performance insights to the cloudwatch performance insights by November 2025. This variable will allow for migrating.

references

@cdobbyn cdobbyn requested review from a team as code owners May 30, 2025 16:20
@mergify mergify bot added the triage Needs triage label May 30, 2025
@RoseSecurity
Copy link
Contributor

RoseSecurity commented Jun 5, 2025

/terratest

cdobbyn added 3 commits July 15, 2025 22:13
@cdobbyn
feat(rds): add database_insights_mode
f035825
@cdobbyn
fix: invalid null value
4da60d8 
The value for `database_insights_mode` can only be one of: "standard" or "advanced"
@cdobbyn
docs: updated database_insights_mode description
84c41ae 
The description still identified null as a valid value when it is not.
@cdobbyn cdobbyn force-pushed the feat/database-insights-mode branch from fede4fe to 84c41ae Compare July 16, 2025 05:13
@RoseSecurity
Copy link
Contributor

RoseSecurity commented Jul 16, 2025

/terratest

@RoseSecurity
Copy link
Contributor

RoseSecurity commented Jul 16, 2025

Thank you for this update. The tests appear to be failing for an unrelated issue, so I opened #199 to resolve the failing bats tests

@prateekkathal
Copy link

prateekkathal commented Nov 5, 2025

Has this already been made available? The date is fast approaching.

@cdobbyn
Copy link
Contributor Author

cdobbyn commented Dec 10, 2025

@prateekkathal no, they kind of just stopped looking at this PR and I don't have time to continue poking them about it.

@prateekkathal
Copy link

prateekkathal commented Dec 10, 2025

@prateekkathal no, they kind of just stopped looking at this PR and I don't have time to continue poking them about it.

Yeah, probably it'll be re-prioritized once AWS starts through warnings/errors. Just a waiting game I guess. Thanks!

@RoseSecurity
Copy link
Contributor

RoseSecurity commented Dec 10, 2025

/terratest

@mergify mergify bot removed the triage Needs triage label Dec 11, 2025
@RoseSecurity
Copy link
Contributor

RoseSecurity commented Dec 11, 2025

Apologies on the hold up on this PR. The bats tests are failing for an unrelated issue, and I have a fix out that addresses this so that we can get this merged. Working on this today

@RoseSecurity
Copy link
Contributor

RoseSecurity commented Dec 11, 2025

/terratest

@RoseSecurity RoseSecurity merged commit 8291837 into cloudposse:main Dec 11, 2025
16 checks passed
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

These changes were released in v1.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RoseSecurity RoseSecurity RoseSecurity approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new attribute: database_insights_mode

3 participants

@cdobbyn @RoseSecurity @prateekkathal