Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renamed create_s3_directory_bucket to conform to cloudposse naming convention #258

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: renamed create_s3_directory_bucket to conform to cloudposse naming convention #258

wants to merge 3 commits into from

Conversation

mayank0202
Copy link
Contributor

@mayank0202 mayank0202 commented Nov 13, 2024 •
edited
Loading

What:

  • changed the naming convention as per cloudposse standards for s3_directory variable

Related to this comment:

#240 (comment)

@mayank0202 mayank0202 requested review from a team as code owners November 13, 2024 18:51
@mergify mergify bot added the triage Needs triage label Nov 13, 2024
@mayank0202 mayank0202 mentioned this pull request Nov 13, 2024
Merged
nitrocode
nitrocode previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@nitrocode nitrocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id like to approve and merge, however this input has been available for 3 months. We may need to add the old variable to variables-deprecated.tf for backwards compatibility. It can probably be removed in the next major version.

cc @Nuru @osterman for visibility

@mergify mergify bot removed the triage Needs triage label Nov 14, 2024
nitrocode
nitrocode reviewed Nov 14, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@mergify mergify bot added the triage Needs triage label Nov 14, 2024
nitrocode
nitrocode previously approved these changes Nov 14, 2024
View reviewed changes
@mergify mergify bot removed the triage Needs triage label Nov 14, 2024
@nitrocode
Copy link
Member

/terratest

@nitrocode nitrocode added patch A minor, backward compatible change bugfix Change that restores intended behavior labels Nov 14, 2024
@nitrocode nitrocode changed the title Changed the naming convention in variables fix: renamed create_s3_directory_bucket to conform to cloudposse naming convention Nov 14, 2024
@mergify Mergify
Copy link

mergify bot commented Nov 14, 2024

💥 This pull request now has conflicts. Could you fix it @mayank0202? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Nov 14, 2024
@mergify mergify bot removed the conflict This PR has conflicts label Nov 14, 2024
@joe-niland
Copy link
Member

Id like to approve and merge, however this input has been available for 3 months. We may need to add the old variable to variables-deprecated.tf for backwards compatibility. It can probably be removed in the next major version.

@nitrocode this seems like a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank0202 @nitrocode @joe-niland