Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullification of customer_gateway_ip_address #39

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Allow nullification of customer_gateway_ip_address #39

merged 7 commits into from
Aug 28, 2024

Conversation

LawrenceWarren
Copy link
Contributor

what

  • Allow the nullification of customer_gateway_ip_address
  • If this is done, certain resources that are created by default will not be created

why

  • This module creates a range of VPN Gateway resources
  • 3 of them are created by default
    • aws_vpn_gateway.default
    • aws_customer_gateway.default
    • aws_vpn_connection.default
  • However, some use cases may not need the customer gateway or the VPN connection
  • For example, some VPN Gateways may be used in conjunction with virtual interfaces to allow VPN to VPN communication

@LawrenceWarren LawrenceWarren requested review from a team as code owners March 26, 2024 15:30
@mergify mergify bot added the triage Needs triage label Mar 26, 2024
@aknysh
Copy link
Member

aknysh commented Aug 28, 2024

/terratest

@aknysh aknysh added minor New features that do not break anything and removed triage Needs triage labels Aug 28, 2024
aknysh
aknysh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @LawrenceWarren

@aknysh aknysh merged commit f1f7c57 into cloudposse:main Aug 28, 2024
34 of 35 checks passed
@github-actions GitHub Actions
Copy link

These changes were released in v1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LawrenceWarren @aknysh