Added VPN Tunnel Phase 1/2 Lifetimes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpschafer
force-pushed
the
tunnel-lifetimes
branch
from
d7db691
to
7fe4074
Compare
|
/terratest |
gberenice
requested changes
Oct 17, 2024
There was a problem hiding this comment.
@jpschafer could you please fix the variable usage as suggested and run fmt?
Co-authored-by: Veronika Gnilitska <[email protected]>
|
/terratest |
|
These changes were released in v1.5.0. |
|
@gberenice Just wanted to say thank you for helping me out in merging this and letting me contribute to this project. You all do great work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Added Tunnel 1/2 Phase 1/2 Lifetime Variables
why
So I can add custom lifetimes outside of the defaults for customers who have different lifetimes set for their end of the tunnel.
references
#54
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpn_connection#tunnel1_phase1_lifetime_seconds
The only issue to note is that in the AWS Console, you will see 28800 and 3600 respectively instead of "default" for each. I wasn't sure If that really matters but it's the only issue I could think of. I'm open to suggestions on preferences regarding this variable that is technically optional. I wasn't sure if setting it to null would create the same behavior.