Add variable for customer gateway device name #57
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oc-christopher-billett
changed the title
|
💥 This pull request now has conflicts. Could you fix it @oc-christopher-billett? 🙏 |
|
@johncblandii @jamengual - Could I get a review on this please? |
jamengual
requested changes
Nov 8, 2024
|
@johncblandii @jamengual - Could I get a review on this again please? |
|
/terratest |
jamengual
approved these changes
Nov 16, 2024
|
Thanks @oc-christopher-billett for the contribution |
|
These changes were released in v1.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Set the customer gateway device name to be a variable
why
To stop it rebuilding on existing VPN's with it not set
references
closes #56