fix race conditions on stage/unstage volume #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alakae
reviewed
Dec 17, 2025
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
6 times, most recently
from
4f1856c to
39b17bf
Compare
udevadm when called concurrently may potentially redo symlinks. Adding a lock, so if multiple pods attach at the same time, we don't call udevadm concurrently. Adjusts the order so we first check if the device is available, before doing udevadm calls. Adjust order of udevadm calls itself: first trigger, then settle. Reason: - settle waits for new events to finish - trigger triggers new events but doesn't wait for them Improve logging and increase the amount of logs (in debug level) to potentially debug issues with more data.
- add volume locks to avoid concurrent operations on the same volume - add detection if symlinks don't add up to the right volume - increase logging once more - test: add concurrency/race condition tests - fix ptr/nonptr receiver - add lint target and fix lint errors
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
from
9952c20 to
cbcd901
Compare
Collaborator
Author
|
workflow |
alakae
reviewed
Jan 13, 2026
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
3 times, most recently
from
7c89877 to
e60759c
Compare
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
2 times, most recently
from
9d559f6 to
74e8df1
Compare
adressed review comments and cleaned up CHANGELOG etc. to prepare for stable release
mweibel
force-pushed
the
release/3.5.7-prerelease
branch
from
74e8df1 to
904c815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of race conditions with node stage/unstage etc. calls.
adjust udevadm calls
udevadm when called concurrently may potentially redo symlinks.
Adding a lock, so if multiple pods attach at the same time, we don't
call udevadm concurrently.
Adjusts the order so we first check if the device is available, before
doing udevadm calls.
Adjust order of udevadm calls itself: first trigger, then settle.
Reason:
improve node stage volume mounting
lint issues