-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Organize the observability components of Cloudwego #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obs-logging
这块其实也是依赖 otel
库的,本质其实也是基于日志库的切面能力来集成 otel
相关能力
可以考虑和上面的 instrumentation
命名规范对齐
CI workflow 参考这个模板更新下,可以做一些调整。首先保障 CI 测试能通过,包括静态检测、lint 和 Copyright header 等。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Refactor
(Optional) Translate the PR title into Chinese.
整合cloudwego的可观测性组件
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
整合hertz和kitex生态的logging/obs- logging,obs,prom。将prom和otel的打点行为(count计数,histogram的record)抽象出一个metric,修改了otel和prom的统计请求数,统计时延逻辑,暴露了统计请求数,统计时延逻辑的接口
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: