Open
Conversation
Add comprehensive ImageConfig support to the Gemini model component, allowing users to configure image generation parameters. Changes: - Add ImageConfig field to Config struct for default configuration - Add imageConfig field to ChatModel struct for runtime storage - Initialize imageConfig in NewChatModel from Config - Add WithImageConfig option function in option.go - Update genInputAndConf to support both default and per-call ImageConfig This implementation follows the same pattern as ThinkingConfig, supporting both default configuration during model creation and dynamic override during Generate/Stream calls.
Contributor
|
@dcsunny Thank you for submitting this PR. The latest version now supports the ImageConfig configuration, so you can use the latest release. We appreciate your support for eino again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive
ImageConfigsupport to the Gemini model component, allowing users to configure image generation parameters.Changes
ImageConfigfield toConfigstruct for default configurationimageConfigfield toChatModelstruct for runtime storageimageConfiginNewChatModelfromConfigWithImageConfigoption function inoption.gogenInputAndConfto support both default and per-callImageConfigImplementation Details
This implementation follows the same pattern as
ThinkingConfig, supporting both:Config.ImageConfigGenerate/Streamcalls viaWithImageConfig()Usage Example