Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: update kitex code and remove apache thrift api usage #163

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

HeyJavaBean
Copy link
Member

@HeyJavaBean HeyJavaBean commented Dec 19, 2024

What type of PR is this?

optimize: remove apache dependency

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional): 将 kitex 代码和版本升级到 v0.12.0,并移除了除了 kitex_gen 以外,对 apache thrift 库的使用,改到了 github.com/cloudwego/gopkg 下的用法

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:


zh: 我们需要您为每个新的 example 添加 run.sh 与 test.sh 以便于用户运行和 CI 测试,如果您不知道如何添加,请参考其他 example 的 run.sh 与 test.sh 文件。

en: We need you to add run.sh and test.sh for each new example so that users can run and CI test. If you don't know how to add, please refer to the run.sh and test.sh files of other examples.

@HeyJavaBean HeyJavaBean requested review from a team as code owners December 19, 2024 08:09
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_dependency branch 8 times, most recently from ff6813a to 8588f96 Compare December 19, 2024 09:59
@GuangmingLuo
Copy link
Member

@HeyJavaBean 能否在 PR 描述里面补充下如何更新 kitex_gen 的命令行例子

@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_dependency branch from 8588f96 to 7badb94 Compare December 19, 2024 11:08
@HeyJavaBean
Copy link
Member Author

@HeyJavaBean 能否在 PR 描述里面补充下如何更新 kitex_gen 的命令行例子

补充在 readme 里了。话说之前 easy note 这些项目完全没有代码更新脚本........太难顶了

@HeyJavaBean HeyJavaBean changed the title optimize: remove apache dependency optimize: update kitex code and remove apache thrift api usage Dec 19, 2024
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_dependency branch from 7badb94 to 996f665 Compare December 19, 2024 11:56
@HeyJavaBean HeyJavaBean force-pushed the optimize/remove_apache_dependency branch from 996f665 to d5a4a8a Compare December 19, 2024 12:00
@GuangmingLuo GuangmingLuo merged commit b4ec9ca into main Dec 23, 2024
5 checks passed
@GuangmingLuo GuangmingLuo deleted the optimize/remove_apache_dependency branch December 23, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants