Skip to content

Commit

Permalink
fix: streaming call received empty trailers (#103)
Browse files Browse the repository at this point in the history
  • Loading branch information
DMwangnima authored Nov 28, 2024
1 parent a296bfd commit f7a0cfe
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions thrift_streaming/thrift_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ import (
"time"

"github.com/bytedance/gopkg/cloud/metainfo"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/a/b/c"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/combine"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/combine/combineservice"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/echo/abcservice"
"github.com/cloudwego/kitex/client"
"github.com/cloudwego/kitex/client/streamclient"
"github.com/cloudwego/kitex/pkg/endpoint"
Expand All @@ -44,6 +40,11 @@ import (
"github.com/cloudwego/kitex/server"
"github.com/cloudwego/kitex/transport"

"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/a/b/c"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/combine"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/combine/combineservice"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/echo/abcservice"

"github.com/cloudwego/kitex-tests/pkg/test"
"github.com/cloudwego/kitex-tests/pkg/utils/serverutils"
"github.com/cloudwego/kitex-tests/thrift_streaming/kitex_gen/echo"
Expand Down Expand Up @@ -791,6 +792,12 @@ func TestThriftStreamingMetaData(t *testing.T) {
got := headerReceived[k]
test.Assertf(t, reflect.DeepEqual(got, expected), "key = %v, got = %v, expected = %v", k, got, expected)
}
resp, err := stream.Recv()
test.Assert(t, err == nil, err)
test.Assert(t, resp.Message == "ok", resp.Message)
// expect to receive io.EOF, which means the client has received the trailers
_, err = stream.Recv()
test.Assert(t, err == io.EOF, err)

trailerReceived := stream.Trailer()
klog.Infof("trailerReceived: %v", trailerReceived)
Expand Down

0 comments on commit f7a0cfe

Please sign in to comment.