Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gRPC): add grpc client conn dump to help debug the conn and stream status #1702

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Feb 14, 2025

…status

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat(gRPC): 添加 grpc client 的连接 dump 信息帮助排查 conn 和 stream 的状态

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ppzqh ppzqh requested review from a team as code owners February 14, 2025 09:24
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from 418091f to ec38d8b Compare February 14, 2025 09:42
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 22.47191% with 69 lines in your changes missing coverage. Please review.

Project coverage is 51.67%. Comparing base (2ef26ea) to head (08ef8d4).
Report is 168 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/nphttp2/grpc/http2_client.go 0.00% 49 Missing ⚠️
pkg/remote/trans/nphttp2/grpc/transport.go 0.00% 15 Missing ⚠️
pkg/remote/trans/nphttp2/conn_pool.go 80.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1702       +/-   ##
============================================
- Coverage    69.69%   51.67%   -18.02%     
============================================
  Files          298      404      +106     
  Lines        21512    37407    +15895     
============================================
+ Hits         14992    19329     +4337     
- Misses        5272    16822    +11550     
- Partials      1248     1256        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from ec38d8b to e7e0b16 Compare February 17, 2025 02:18
@ppzqh ppzqh force-pushed the feat/grpc_conn_monitor branch from 8ca6d51 to 08ef8d4 Compare February 17, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant