Skip to content

WIP: fix: add proactive check in connpool for gonet conn #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ppzqh
Copy link
Contributor

@ppzqh ppzqh commented Jun 6, 2025

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ppzqh ppzqh requested review from a team as code owners June 6, 2025 03:36
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 74.01575% with 33 lines in your changes missing coverage. Please review.

Project coverage is 60.47%. Comparing base (14199d5) to head (90a1a6d).

Files with missing lines Patch % Lines
pkg/remote/connpool/long_pool.go 70.00% 17 Missing and 1 partial ⚠️
internal/remote/conn_check.go 74.28% 6 Missing and 3 partials ⚠️
pkg/remote/trans/gonet/conn.go 71.42% 3 Missing and 1 partial ⚠️
pkg/remote/trans/gonet/dialer.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1790      +/-   ##
===========================================
+ Coverage    60.31%   60.47%   +0.16%     
===========================================
  Files          381      382       +1     
  Lines        34515    34627     +112     
===========================================
+ Hits         20816    20940     +124     
+ Misses       12419    12409      -10     
+ Partials      1280     1278       -2     
Flag Coverage Δ
integration 48.15% <39.63%> (+<0.01%) ⬆️
unit 50.89% <55.11%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppzqh ppzqh force-pushed the fix-gonet-checkconn branch 2 times, most recently from f7db42d to 86bdb49 Compare June 11, 2025 07:53
@ppzqh ppzqh force-pushed the fix-gonet-checkconn branch from 86bdb49 to 90a1a6d Compare June 11, 2025 08:28
@ppzqh ppzqh changed the title fix: add proactive check in connpool for gonet conn WIP: fix: add proactive check in connpool for gonet conn Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant